🦋 Changeset detected

Latest commit: 4f118d2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacob-ebey It seems like all is fine to be merged and released.
Anything that's holding us back to do so?

I don't think we plan to maintain this package any longer because we can use built in node fetch

@brophdawg11 If so, we should maybe add a deprecation notice to the repo + npm packages and maybe also archive the repo?

@brophdawg11 Just noticed @remix-run/web-fetch is still used by create-react-router though.
Since we're using the agent option (see node-fetch's docs), we can't just remove @remix-run/web-fetch as it's not supported by native Fetch API 😢

we should maybe add a deprecation notice to the repo + npm packages and maybe also archive the repo?

yeah probably - I'll check with the team

What exactly is agent doing for us? I just updated a local create-react-router build to use native fetch and commented out the agent line and it worked without issue...

I did find this as a potential way to do agent-like stuff via dispatcher - but we should only look into that ff we can find specific scenarios where native fetch breaks without agent

agent allows specifyng a custom HTTP agent for things like force-using a specific IP version (IPv4/IPv6) and other low-level stuff

@talentlessguy We're only using the agent option in 2 places in create-react-router:

let response = await fetch(releaseUrl, {
  agent: agent("https://api.github.com"),
  headers,
});

let resourceUrl = tarballUrl; // could be a user-provided URL

// ...

resourceUrl = `https://api.github.com/repos/${info.owner}/${info.name}/releases/assets/${assetId}`;

// ...

let response = await fetch(resourceUrl, {
    agent: agent(resourceUrl),
    headers,
  });

where

import { ProxyAgent } from "proxy-agent";

const defaultAgent = new ProxyAgent();
const httpsAgent = new ProxyAgent();
httpsAgent.protocol = "https:";
function agent(url: string) {
  return new URL(url).protocol === "https:" ? httpsAgent : defaultAgent;
}

I guess that's showing us that using the agent option isn't necessary?
Or am I missing some things here?

CC/ @markdalgleish since you did both the original create-remix & create-react-router

I created a PR to remove @remix-run/web-fetch usage and go with native Fetch, but that seems to trigger a test failure of a test that's actually using an env var proxy.
remix-run/react-router#14140 (comment)

Not sure if that's a use-case we want to support though 🤔